feat: add points on completing quest and achievement #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th0rgal
requested changes
Nov 9, 2023
src/utils.rs
Outdated
| } | ||
|
|
||
| // get total experience for a specific quest id from quest collection | ||
| let quests_collection: Collection<QuestDocument> = self.db.collection("quests"); |
There was a problem hiding this comment.
Please try to minimize the amount of queries you do. For example you can use facets.
src/utils.rs
Outdated
| let mut result = true; | ||
|
|
||
| // get completed tasks for a specific quest id from completed_tasks collection | ||
| for &item in total_tasks.iter() { |
There was a problem hiding this comment.
One thing you can do is an aggregation to get the amount of tasks associated to a quest and the amount completed by the user, and check if those are equal, if so it means the user completed the quest. If you can do it in the same query which completes the task, that would be perfect.
Th0rgal
added
❌ Change request
ayushtom
added
🔥 Ready for review
Th0rgal
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100
closes #99